Repository navigation
UX: Use sentence case for video strings and fix the preview placeholder - #109
Merged
ZogStriP merged 1 commit intoOct 23, 2026
Merged
Conversation
Previously, the plugin's video strings used Proper Case, unlike the rest of Discourse, and the ingest error misspelled "ingest". The composer preview also wrapped the video placeholder in a `<p>`, which can't contain a `<div>`, so browsers closed the paragraph early and left empty paragraphs around the placeholder. This change switches those strings to sentence case, fixes the typo, and renders the preview placeholder without the wrapping `<p>`.
This was referenced Oct 22, 2026
Grubba27
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the plugin's video strings used Proper Case, unlike the rest of Discourse, and the ingest error misspelled "ingest". The composer preview also wrapped the video placeholder in a
<p>, which can't contain a<div>, so browsers closed the paragraph early and left empty paragraphs around the placeholder.This change switches those strings to sentence case, fixes the typo, and renders the preview placeholder without the wrapping
<p>.The
Discourse Videoadmin settings category is left as is, since it is the plugin's name.Part of a stack of PRs, to be merged in order: