Skip to content

Fix Issue 11455 - Overriding template methods should raise a compile … #15350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RazvanN7 merged 2 commits into from
Jul 17, 2023
Merged

Fix Issue 11455 - Overriding template methods should raise a compile … #15350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dff2e4f
Fix Issue 11455 - Overriding template methods should raise a compile …
ntrel Jun 26, 2023
fc0ac3d
Change to deprecation; tweak messages
ntrel Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler/src/dmd/parse.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4611,6 +4611,13 @@ class Parser(AST, Lexer = dmd.lexer.Lexer) : Lexer
*/
if (tpl)
{
// @@@DEPRECATED_2.114@@@
// Both deprecated in 2.104, change to error
if (storage_class & STC.override_)
deprecation(loc, "a function template is not virtual so cannot be marked `override`");
else if (storage_class & STC.abstract_)
deprecation(loc, "a function template is not virtual so cannot be marked `abstract`");

// Wrap a template around the function declaration
auto decldefs = new AST.Dsymbols();
decldefs.push(s);
Expand Down
18 changes: 18 additions & 0 deletions compiler/test/fail_compilation/template_function_oop.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
REQUIRED_ARGS: -de
TEST_OUTPUT:
---
fail_compilation/template_function_oop.d(16): Deprecation: a function template is not virtual so cannot be marked `override`
fail_compilation/template_function_oop.d(17): Deprecation: a function template is not virtual so cannot be marked `abstract`
---
*/
class C
{
void f();
}

class D : C
{
override void f()() {}
abstract void g()();
}