fix #23335 - some lowerings not shown with -vcg-ast#23336
Open
rainers wants to merge 1 commit into
Open
Conversation
thewilsonator
approved these changes
Jun 29, 2026
rainers
commented
Jun 29, 2026
| { | ||
| buf.put(s.ident.toChars()); | ||
| // after semantic, symbols don't go through a ScopeExp that also shows the template arguments | ||
| if (auto parent = s.toParent()) |
Member
Author
There was a problem hiding this comment.
I'm not so happy with this, it should probably show the fully qualified name instead. This is missing eventually, see for example https://github.com/dlang/dmd/pull/23336/changes#diff-f6ad7de81f2a7f7e855f3bca2875959556956886416253379e8602d7790fc497R104
Member
Author
There was a problem hiding this comment.
Now showing the fully qualified names for non-locals/fields here. Sometimes a bit too verbose, but probably better than omitting information.
rainers
force-pushed
the
issue23335
branch
2 times, most recently
from
185e482 to
85d33c3
Compare
forward to lowered AST in CastExp, EqualExp and ConstructExp, print fully qualified for non-locals/fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forward to lowered AST in CastExp, EqualExp and ConstructExp, add template arguments