-
-
Notifications
You must be signed in to change notification settings - Fork 703
Replace MSVCR120.dll fallback with the Universal CRT on Windows. #23345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+211
−61
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ad6002
Deprecate MSVCR120.dll fallback and replace with the Universal CRT.
LightBender ef88797
Add deprecation comments.
LightBender b52fe8c
Fix broken test by making the deprecation message only appear when ms…
LightBender 50acd4a
Use DMD provided MinGW ucrtbase.lib as a fallback instead msvcrt120. …
LightBender 16bbd50
Simplify VC tool chain detection by enumerating the directory itself.
LightBender 8f00e22
Fix nits.
LightBender 382c0b0
Fix whitespace
LightBender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| UCRT is now used for the C runtime on Windows | ||
|
|
||
| DMD on Windows now uses the Universal CRT (UCRT) for its C runtime in all cases. | ||
|
|
||
| For installations with Visual Studio 2015 (or later) or the Windows 10 SDK, the default | ||
| C runtime is unchanged: it remains $(TT libcmt), which statically links the UCRT. | ||
|
|
||
| When no such Visual C installation is found, DMD now falls back on the UCRT-based | ||
| libraries bundled in the MinGW folder shipped with DMD ($(TT ucrtbase.lib) together with | ||
| $(TT vcruntime140.lib)), instead of the old $(TT msvcrt120) runtime which did not support | ||
| modern format specifiers such as `%zd`. This fallback is fully supported. | ||
|
|
||
| If no UCRT-capable toolchain is detected and no $(TT -mscrtlib) switch is given, DMD now | ||
| reports a clear error instead of silently producing a non-working link. | ||
|
|
||
| Detection of Visual Studio versions older than 2015 (2008 - 2013) is deprecated, because | ||
| those versions predate the UCRT. Falling back on such an installation emits a deprecation | ||
| warning. | ||
|
|
||
| The $(TT -mscrtlib) switch is unchanged and can still be used to select any C runtime, | ||
| including $(TT msvcrt) (dynamic), the debug variants $(TT libcmtd) / $(TT msvcrtd), or a | ||
| legacy $(TT msvcrtNNN) runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.