Skip to content

Feat/powerbi importer#17

Merged
dmaresma merged 11 commits into
release/mckesson_datahub202606from
feat/powerbi_importer
Jun 5, 2026
Merged

Feat/powerbi importer#17
dmaresma merged 11 commits into
release/mckesson_datahub202606from
feat/powerbi_importer

Conversation

@dmaresma
Copy link
Copy Markdown
Owner

@dmaresma dmaresma commented Jun 4, 2026

  • Tests pass (uv run pytest)
  • Code formatted (uv run ruff check --fix && uv run ruff format)
  • README.md updated (if relevant)
  • CHANGELOG.md entry added

dmaresma and others added 10 commits May 13, 2026 19:09
* init snowflake importer

* ruff format fix

* add documentation

* improve export query and fix ordered columns position, disable empty attributes add sort by schema.name and properties by ordinal_position

* inject account in server.account

* improve connector login

* ruff

* rename customProperties ordinalPosition

* refactor snowflake-db and add test_import_snowflake

* ruff lint applied

* typo during refactor

* force string, char as varchar for physicalType

* add columns tags, customProperties: precisition, scale, autoIncrement, defaultValue, Roles in server

* refactor

* turn snowflake tags as str Key=Value array

* added tests and key authentication

* add DMF as quality (schema & properties) based on last results

* merged upstream changes

* removed temp file

* fix bug

* typo on description

* test success

* double-quoted schema identifiers and authenticator documentation

* ruff format

* detect snowflake_authenticator in env. variable

* ruff format

* remove_unexpect_characters

* remove schema

* fix test failure

* implement server mandatory properties

* remove typo quote

* refactor use of the odcs_helper (improved)

Co-authored-by: Copilot <copilot@github.com>

* remove un used package

* linting format and fixes

Co-authored-by: Copilot <copilot@github.com>

* add property sort by ordinal position and schema sort by name

Co-authored-by: Copilot <copilot@github.com>

* run ruff format fix

* test fix

* improve physicalType extraction

* physicalType ruff format 'n check

* autoincrement wrong physicaltype format, Tags issues

* fix reinject unique property when IDENTITY found

* physicalType drive the logicalType using sql import mapping

* use custom --schema option to align with v0.12.0

* use snake_case for variable names

* typos & ruff format

* Snowflake environment variable table updated

* refactor based on comments

* refactor

* ruff applied

* test fix

* refactor with github copilot

* format fix and comment changes applied

* fix test sequence

* pass the test

* error code typo

* Apply suggestion from @jochenchrist

* Apply suggestion from @jochenchrist

* fix command line example

* Apply suggestion from @jochenchrist

* Apply suggestion from @jochenchrist

---------

Co-authored-by: Bodo Huesemann <bhuesemann@users.noreply.github.com>
Co-authored-by: Jochen Christ <jochen.christ@entropy-data.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Jakob Schödl <jakob.schoedl@entropy-data.com>
@dmaresma
Copy link
Copy Markdown
Owner Author

dmaresma commented Jun 5, 2026

@copilot resolve the merge conflicts in this pull request

…into feat/powerbi_importer

# Conflicts:
#	README.md
#	datacontract/command_import.py
#	datacontract/imports/importer.py
#	datacontract/imports/importer_factory.py
Copy link
Copy Markdown

Copilot AI commented Jun 5, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit 33c6dde. The four conflicting files were resolved as follows:

  • datacontract/imports/importer.py — kept both powerbi and snowflake enum values
  • datacontract/imports/importer_factory.py — kept both PowerBI and Snowflake lazy importer registrations
  • datacontract/command_import.py — fixed the previously corrupt import_powerbi command (which was missing owner, id, and debug parameters due to a prior bad merge) and kept both import_powerbi and import_snowflake subcommands
  • README.md — kept the updated Snowflake connector env-var description from HEAD, and included both powerbi and snowflake rows in the import commands table

@dmaresma dmaresma merged commit 5154085 into release/mckesson_datahub202606 Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants