Conversation
khintz
added
CI/CD
|
@khintz let me know when you are ready for me to review it |
Contributor
Author
Now :) I was just testing another minor thing since I thought you left for the day. |
elbdmi
requested changes
Apr 21, 2026
elbdmi
left a comment
elbdmi
left a comment
There was a problem hiding this comment.
Nice implementation overall. I’m requesting changes for one thing before approving.
The workflow currently only publishes on version tags but the README says main pushes publish too.
…s on tagged versions
elbdmi
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a github action to build and push a public image to ghcr.io.