Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce required gem dependencies for omniauth-keycloak consumers by removing json-jwt usage in favor of the jwt gem (already pulled in via omniauth-oauth2), and includes CI/RuboCop maintenance updates.
Changes:
- Replace
json-jwtdependency/require withjwt. - Refactor
setup_phaseby extracting OpenID configuration and JWKS fetching into private helper methods. - Update CI workflows to run on pushes to any branch and bump checkout action version; regenerate RuboCop TODOs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| omniauth-keycloak.gemspec | Swap json-jwt dependency for jwt. |
| lib/omniauth/strategies/keycloak.rb | Switch JWT handling libraries and refactor Keycloak discovery/JWKS fetching. |
| .rubocop_todo.yml | Regenerated RuboCop TODO configuration. |
| .github/workflows/rubocop.yml | Run on any push; bump checkout action version. |
| .github/workflows/ci.yml | Run on any push. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is an effort to reduce the number of gems consumers need to install in their application. Since `omniauth-keycloak` depends on `omniauth-oauth2`, and the latter includes the `jwt` gem, we don't need to depend on `json-jwt`.
dmke
force-pushed
the
reduce-dependencies
branch
from
April 30, 2026 23:16
0b40cb6 to
814a10b
Compare
Owner
Author
|
@copilot review again. |
Extracts fetching of configuration and certificates into seperate methods.
dmke
force-pushed
the
reduce-dependencies
branch
from
April 30, 2026 23:27
814a10b to
0aac548
Compare
dmke
force-pushed
the
reduce-dependencies
branch
from
April 30, 2026 23:29
0aac548 to
6a57496
Compare
Reviewed. The method |
dmke
force-pushed
the
reduce-dependencies
branch
from
April 30, 2026 23:35
365b031 to
6a57496
Compare
Using `OmniAuth.config.test_mode` masks a lot of code that is otherwise not tested. This adds a full-stack integration spec (using Rack::Test as mock Keycloak server). Agent-Logs-Url: https://github.com/dmke/omniauth-keycloak/sessions/45616c39-f544-4ee7-b58e-531f3701792c Co-authored-by: dmke <327411+dmke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a duplicate of ifad#25, but I want to see what Copilot is capable of.)