fix(cloudflare): quiet no-op env reload noise in varlock-wrangler#885
Closed
WalksWithASwagger wants to merge 1 commit into
Closed
fix(cloudflare): quiet no-op env reload noise in varlock-wrangler#885WalksWithASwagger wants to merge 1 commit into
WalksWithASwagger wants to merge 1 commit into
Conversation
Ignore fs.watch events when mtime is unchanged, and only log same-content skip-restart messages under VARLOCK_DEBUG. Fixes noisy macOS/editor opens during varlock-wrangler dev (dmno-dev#845). Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
@theoephraim I'm assuming #884 covers this? |
Member
|
Yeah pretty sure it does. Will verify. |
Member
|
this is handled by #884 - thanks for this though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.watchevents invarlock-wrangler devwhen a watched env file'smtimeis unchanged (common macOS/editor/agent open noise).VARLOCK_DEBUGso same-content saves stay quiet by default.@varlock/cloudflare-integration.Fixes #845
Test plan
bun run test:ciinpackages/integrations/cloudflare(5 tests)bun run build:libs(includes cloudflare package)bun run lint:fixon touched filesvarlock-wrangler dev, open.env.schemafrom an editor/agent without saving, confirm no repeated no-op reload logsVARLOCK_DEBUG=1: same-content save still logs the no-op skip message