fix: massive PNG save performance regression (2.6x speedup) #150
+170
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyassanthu77
force-pushed
the
main
branch
2 times, most recently
from
f83b835 to
be18906
Compare
shreyassanthu77
force-pushed
the
main
branch
from
be18906 to
8283090
Compare
dmtrKovalenko
approved these changes
Nov 14, 2025
…ustom scanline impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was massive overhead to using zig IO writer with spng instead of just letting it handle the io.
I could have looked into what was causing the overhead but felt like it wasn't worth it to do :) it now takes just as much time as before the new io impl was added.nvm actually i fixed it lolalso added a benchmark script that i wrote to make testing this easier which could be useful in the future