cmd/secret: use new store #217
Draft
+109
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benehiko
force-pushed
the
cmd/mcp/secret
branch
from
30c9efb to
7a9fceb
Compare
Signed-off-by: Alano Terblanche <[email protected]>
Benehiko
force-pushed
the
cmd/mcp/secret
branch
from
7a9fceb to
816c723
Compare
saucow
reviewed
Nov 6, 2025
Comment on lines
+50
to
+64
| func GetVersion(ctx context.Context) (string, error) { | ||
| var result any | ||
| if err := ClientBackend.Get(ctx, "/versions", &result); err != nil { | ||
| return "", err | ||
| } | ||
| val, err := jsonpath.Get("$.appVersion", result) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| version, ok := val.(string) | ||
| if !ok { | ||
| return "", errors.New("could not get docker desktop version") | ||
| } | ||
| return version, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Do we still need to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did