Skip to content

Conversation

@rafaeljusto
Copy link
Contributor

@rafaeljusto rafaeljusto commented Aug 18, 2025

The secret provided via argument (-e flag) was losing its value before listing the tools. This caused failures to connect to the MCP server.

secrets = append(secrets, servers.Secret{
Name: secretName(name, parts[0]),
Env: parts[0],
Example: "<" + parts[0] + ">",
})

The strategy now is to replace the secret value only when encoding the object to generate the template.

There was also a missing --load flag when executing docker buildx build to correctly load the image into the memory.

WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load

The secret provided via argument (`-e` flag) [1] was losing the value before
listing the tools. This caused failures to connect to the MCP server.

The strategy now is to replace the secret value only when encoding the object
to generate the template.

There was also a missing `--load` flag when executing `docker buildx build` to
correctly load the image into the memory.

[1] https://github.com/rafaeljusto/mcp-registry/blob/17fdb6eb0a4b47d4ac1a33535554a6fa7e2b2dd3/cmd/create/main.go#L177-L181
@rafaeljusto rafaeljusto requested a review from a team as a code owner August 18, 2025 17:54
@ipedrazas ipedrazas merged commit 7da0d3f into docker:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants