Properly invalidate if required attribute/property changes#546
Open
KaneFreeman wants to merge 1 commit intodojo:masterfrom
Open
Properly invalidate if required attribute/property changes#546KaneFreeman wants to merge 1 commit intodojo:masterfrom
KaneFreeman wants to merge 1 commit intodojo:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 117 117
Lines 6513 6515 +2
Branches 1479 1479
=======================================
+ Hits 6346 6348 +2
Misses 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Current
InputValiditymeta andvaliditymiddleware do not invalidate when the required status of a field changes. This results in an outside trigger being required before the correct validity is captured.This change, which is breaking, takes the expected
requiredvalue and compares it to therequiredattribute on theHTMLFormElementnode. If they do not match, it invalidates (same behavior as when the values do not match).