Skip to content

[Pulse demo] psf/requests PR #5922: Always use value of session.verify when set, fixes #5921 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominic097 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Pulse demo] psf/requests PR #5922: Always use value of session.verify when set, fixes #5921 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .pulse-demo/sampled-prs/2026-06-24/upstream-pr-5922.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"author": {
"id": "MDQ6VXNlcjc5NTg0MQ==",
"is_bot": false,
"login": "brmzkw",
"name": "Julien Castets"
},
"baseRefName": "main",
"body": "This fixes https://github.com/psf/requests/issues/5921 where the value of REQUESTS_CA_BUNDLE is read even when certificate verification is disabled through the session.",
"createdAt": "2021-09-01T12:20:19Z",
"files": [
{
"additions": 1,
"changeType": "MODIFIED",
"deletions": 1,
"path": "requests/sessions.py"
},
{
"additions": 12,
"changeType": "MODIFIED",
"deletions": 0,
"path": "tests/test_requests.py"
}
],
"headRefName": "main",
"labels": [],
"number": 5922,
"title": "Always use value of session.verify when set, fixes #5921",
"updatedAt": "2021-09-01T12:47:59Z",
"url": "https://github.com/psf/requests/pull/5922"
}
2 changes: 2 additions & 0 deletions tests/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3092,3 +3092,5 @@ def test_json_decode_errors_are_serializable_deserializable():
)
deserialized_error = pickle.loads(pickle.dumps(json_decode_error))
assert repr(json_decode_error) == repr(deserialized_error)

# Pulse demo seed 2026-06-24: metadata from psf/requests PR #5922