Skip to content

Add the ability to modify request options#20

Open
dr3am3r wants to merge 4 commits into
dominicbarnes:masterfrom
dr3am3r:master
Open

Add the ability to modify request options#20
dr3am3r wants to merge 4 commits into
dominicbarnes:masterfrom
dr3am3r:master

Conversation

@dr3am3r

@dr3am3r dr3am3r commented Jul 11, 2013

Copy link
Copy Markdown

Adds a chaining method to a parent prototype, basically allows to modify request options if needed.

Usage example:

var db = require('couchdb-api').srv('http://hostname:port').db(myDatabase);

db.ddoc(myKey).view(myView).setRequestOptions({
       timeout: 3 * 1000
}).query({
        limit: 1
}, function(err, data) {
        // do something
});

@dominicbarnes

Copy link
Copy Markdown
Owner

The simplicity here is nice, so I would like to include this.

Could you add notes in the README? (I'll include this information in the website/docs)

Also, this is missing some tests, could you add a few of those as well?

@dr3am3r

dr3am3r commented Jul 15, 2013

Copy link
Copy Markdown
Author

Yes sure, will let you know.
However not all tests written by you are passing on my environment, can you
please confirm that they all work for you?

On Thu, Jul 11, 2013 at 4:58 AM, Dominic Barnes notifications@github.comwrote:

The simplicity here is nice, so I would like to include this.

Could you add notes in the README? (I'll include this information in the
website/docs)

Also, this is missing some tests, could you add a few of those as well?


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-20787236
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants