removes duplication of un/directed implementations - #158
Open
davidovich wants to merge 1 commit into
Open
davidovich wants to merge 1 commit into
davidovich wants to merge 1 commit into
Conversation
dominikbraun
self-requested a review
November 18, 2023 06:41
davidovich
force-pushed
the
reduce-duplication
branch
from
December 20, 2023 17:52
e58507d to
cf11227
Compare
Introduces the private graph[K, T] struct to partially implement the Graph[K, T] interface. Only select functions are in their respective directed or undirected implementation files. This reduces most of the duplication that was present in both files. Signed-off-by: davidovich <david.genest@gmail.com>
davidovich
force-pushed
the
reduce-duplication
branch
from
December 20, 2023 18:00
cf11227 to
d312e1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the private graph[K, T] struct to partially implement the Graph[K, T] interface. Only select functions are in their respective directed or undirected implementation files. This reduces most of the duplication that was present in both files.
Although this is a moderate change in size, most of the existing PRs are still relevant because they mostly use the Graph interface - IMHO, this is a sign of good design.