[DOM-57587] Allow same execution names across projects#1
Draft
ddl-ebrown wants to merge 1 commit into
Draft
Conversation
- Typically Flyte is configured so that each project / domain has its
own Kubernetes namespace.
Flyte in Domino overrides this behavior so that all workflows are
launched inside of the domino-compute namespace, given it's currently
not practical within Domino to support additional namespaces
- This patch fixes 2 important things to make this work properly inside
of Flyte:
* it adds a random element to the CR name in Flyte so that the CR is
named by the execution + some unique value when created by
flyteadmin
Without this change, an execution Foo in project A will prevent an
execution Foo in project B from launching, because the name of the
CR thats generated in Kubernetes *assumes* that the namespace the
CRs are put into is different for project A and project B
In Domino, that assumption is wrong
* it makes sure that when flytepropeller cleans up the CR resource
that it uses Kubernetes labels to find the correct CR -- so instead
of assuming that it can use the execution name, it instead uses the
project, domain and execution labels
- The first version of this patch was incomplete and failed to address
the second issue caused by the first change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically Flyte is configured so that each project / domain has its own Kubernetes namespace.
Flyte in Domino overrides this behavior so that all workflows are launched inside of the domino-compute namespace, given it's currently not practical within Domino to support additional namespaces
This patch fixes 2 important things to make this work properly inside of Flyte:
it adds a random element to the CR name in Flyte so that the CR is named by the execution + some unique value when created by flyteadmin
Without this change, an execution Foo in project A will prevent an
execution Foo in project B from launching, because the name of the
CR thats generated in Kubernetes assumes that the namespace the
CRs are put into is different for project A and project B
In Domino, that assumption is wrong
it makes sure that when flytepropeller cleans up the CR resource that it uses Kubernetes labels to find the correct CR -- so instead of assuming that it can use the execution name, it instead uses the project, domain and execution labels
The first version of this patch was incomplete and failed to address the second issue caused by the first change
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link