Skip to content

Conversation

@lbussell
Copy link
Member

This PR targets the main branch because the change will only affect the main and release branches. This change is needed in order to unblock PR validation in #6752.

This should help for #6718, even though that issue only says that the nightly pipeline was reported.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we attempt this before and we ran into issues on release day due to these packages not being mirrored yet? If that's the case, wouldn't we then have issues with the test for the Windows images that get rebuilt after the internal images get published?

@lbussell
Copy link
Member Author

lbussell commented Oct 27, 2025

Didn't we attempt this before and we ran into issues on release day due to these packages not being mirrored yet?

Yes.

If that's the case, wouldn't we then have issues with the test for the Windows images that get rebuilt after the internal images get published?

Yes, potentially. I'm wondering if using NuGet.org will block us on release days due to network isolation policies. Or if it doesn't apply to Docker.

The primary motivation for this change was to get PR validation passing in #6752 because that needed the preview feed for the .NET 10 daily build.

Some potential options that I see are:

  • Always use the NuGet config in tests, but leave it empty on the main branch like before: <configuration></configuration>
  • Have a pipeline parameter that controls whether we use NuGet.org or the mirror on release days only.
  • Have a pipeline parameter that disables tests that require NuGet packages.

I am wondering which/how many Windows tests reach out to NuGet.org. I can try and run an experiment to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants