Fix: avoid crashes on non-breaking spaces in the text. #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when a non-breaking space is in the input text.
Looking at the implementation of
is_list_word, it will always exit when it encounters whitespace; the debug assertion isn't necessary. A look at the function shows that it implements a state machine:stateDiagram-v2 false: return false true: return true [*] --> Numeric: is_numeric [*] --> false: !is_numeric | end of string Numeric --> Numeric: is_numeric Numeric --> false: !is_numeric | end of string Numeric --> Delim: "." | ")" Delim --> false: !end of string Delim --> true: end of string