Repository navigation
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI currently tests on Node 16.x and 18.x. Both lines are end-of-life, so they get no security fixes, including the recent eMudhra certificate fix shipped in Node 22.23.4 and 24.22.1. This moves the matrix to the two supported lines, 22.x and 24.x.
I ran
yarn install && yarn buildlocally on Node 22.23.4 and 24.22.2. All 21 turbo tasks passed, including the Cypress specs.Node 26.x is left out for now: five tests in
packages/arbor-plugins/tests/LocalStorage.test.tsfail there. Node 26 has its own globallocalStorage, and vitest 1.x doesn't stop it from replacing jsdom's (TypeError: Cannot read properties of undefined (reading 'removeItem')). Adding 26.x will need a vitest upgrade first.