Skip to content

Grouped root 'docker-compose.yml' container image updates with the other container images. - #3164

Merged
AlexSkrypnyk merged 2 commits into
mainfrom
feature/renovate-compose
Sep 27, 2026
Merged

AlexSkrypnyk merged 2 commits into
mainfrom
feature/renovate-compose

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

The Container images - All - Major, minor and patch package rule in renovate.json now matches docker-compose.yml in its matchFileNames array alongside .docker/**, .circleci/** and .github/workflows/**, so the four container image pins in the root docker-compose.yml join the same grouped rule as the .docker/** pins.

The rule's matchFileNames never listed docker-compose.yml, even though docker-compose is one of Renovate's enabledManagers and a customManagers regex already tracks the IMAGE: build arg in that file, so every image bump Renovate found there - uselagoon/mysql-8.4 on the database build arg and the database2 image, uselagoon/valkey-8 on redis, selenium/standalone-chromium, and drevops/docker-wait-for-dependencies - fell through to Renovate's defaults: one PR per dependency, with no schedule.

New Lagoon image releases now produce a single grouped PR on the before 3am schedule instead of splitting uselagoon/mysql-8.4 and uselagoon/valkey-8 into separate unscheduled PRs alongside it, and uselagoon/mysql-8.4 - pinned in both docker-compose.yml and .docker/database.dockerfile - no longer updates across two different PRs in the same cycle; no image version, manager, or other package rule changes in this PR.

Before / After

BEFORE
  .docker/**             ─┐
  .circleci/**             ├─▶ ┌──────────────────────────────┐ ─▶ 1 grouped PR
  .github/workflows/**   ─┘    │ Container images - All        │    (before 3am)
                                │ Major, minor and patch        │
                                └──────────────────────────────┘

  docker-compose.yml (4 image pins) ─────────────────────────────▶ Renovate defaults
                                                                     ─▶ 1 PR per dependency
                                                                     ─▶ no schedule

AFTER
  .docker/**             ─┐
  .circleci/**             ├─▶ ┌──────────────────────────────┐ ─▶ 1 grouped PR
  .github/workflows/**   ─┤    │ Container images - All        │    (before 3am)
  docker-compose.yml     ─┘    │ Major, minor and patch        │
                                └──────────────────────────────┘

Changes

  • renovate.json: added "docker-compose.yml" to the matchFileNames array of the Container images - All - Major, minor and patch package rule.
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.json: same one-line addition, kept byte-for-byte identical to the shipped root renovate.json since the installer fixture is a snapshot of it.

Summary by CodeRabbit

  • Chores
    • Automated container image updates now also cover images specified in Docker Compose configuration, alongside existing Docker and workflow configurations. This extends update coverage to another supported configuration type; no changes to application behavior are included.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.json is excluded by !.vortex/installer/tests/Fixtures/**
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: b59f4173-22c7-46b4-9a8f-8bca25bec118

📥 Commits

Reviewing files that changed from the base of the PR and between 982fc0d and 1041a98.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.json is excluded by !.vortex/installer/tests/Fixtures/**

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: d45adfa1-1319-4ef8-8349-581f7a04897a

📥 Commits

Reviewing files that changed from the base of the PR and between 3bdd10d and 51e0a18.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.json is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
  • renovate.json

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The container-image package rule now matches docker-compose.yml alongside the existing Docker and workflow file paths.

Changes

Container image matching

Layer / File(s) Summary
Extend container-image file matching
renovate.json
The container-image package rule now includes docker-compose.yml in its file paths.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 982fc

The change is limited to matching the root Compose file for the existing container-image rule; no material merge risk is evident from the supplied review context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: grouping root docker-compose.yml container image updates with the existing container image rule.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

A rabbit checks the paths with care
Compose files now join the lair
Docker rules include one more
A tidy match beside the door
Then off I hop across the floor

Comment @coderabbitai help to get the list of available commands.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6ab9941efb745b02671e0a6c--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

This comment has been minimized.

@AlexSkrypnyk
AlexSkrypnyk force-pushed the feature/renovate-compose branch from 982fc0d to 1041a98 Compare September 27, 2026 21:55
@AlexSkrypnyk
AlexSkrypnyk enabled auto-merge (squash) September 27, 2026 21:56
@AlexSkrypnyk AlexSkrypnyk added the AUTOMERGE Pull request has been approved and set to automerge label Sep 27, 2026
@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (230/230)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (230/230)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.65%. Comparing base (29967b2) to head (1041a98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   87.02%   86.65%   -0.37%     
==========================================
  Files         114      106       -8     
  Lines        5255     5089     -166     
  Branches       49        3      -46     
==========================================
- Hits         4573     4410     -163     
+ Misses        682      679       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk
AlexSkrypnyk merged commit 9bea17d into main Sep 27, 2026
38 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/renovate-compose branch September 27, 2026 22:18
@AlexSkrypnyk AlexSkrypnyk added this to the 1.42.0 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AUTOMERGE Pull request has been approved and set to automerge

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant