Repository navigation
Updated 'drevops/mariadb-drupal-data' to '26.10.0'. - #3176
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review. WalkthroughThe nightly database image and test seed asset references now use release 26.10.0. The seed asset script also uses the checksum for that release. ChangesRelease 26.10.0 update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The release references are aligned, and the seed asset passed checksum verification. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
A rabbit checks the version line Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6ac2ebfa28604fb0e0058c85--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
0c95c51 to
ce15fba
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ce15fba to
620b3b0
Compare
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
|
Code coverage (threshold: 90%) Per-class coverage |
|
Code coverage (threshold: 90%) Per-class coverage |
Summary
The
database-nightlyjob in.circleci/config.ymlnow pinsVORTEX_DB_IMAGE_BASEtodrevops/mariadb-drupal-data:26.10.0, andSEED_URL/SEED_SHA256in.vortex/tests/update-test-assetspoint at the26.10.0release asset ofseed.sh, so both places Vortex pins the image track the same release.The pins sat on 2 older releases,
26.8.1for the image and26.7.0forseed.sh, so they missed what26.10.0changes for every database-in-image site: when the data directory is already populated,entrypoint.bashwrites the password-less client.my.cnfinto${MARIADB_DATA_DIR}(/home/db-data) and adds a default[mysql] database=,FORCE_MYSQL_UPGRADEbecomes a deprecated alias ofMARIADB_FORCE_UPGRADE, and the base image moves touselagoon/mariadb-10.11-drupal:26.9.0.seed.shgainsSANITIZE_PROCEEDandSANITIZE_FILE, renamesDST_IMAGEtoDESTINATION_IMAGE, and no longer prints a Docker Hub link or skips:latestfor destinations on other registries.After merge, CircleCI projects scaffolded or updated from the template get
26.10.0indatabase-nightly, and the nextupdate-test-assetsrun seeds with the26.10.0script. PR CI executes neither pin, becausedatabase-nightlyruns only on thenightly-dbschedule andupdate-test-assetsis run by hand, so the release was verified locally (see Verification). The installer fixtures don't change: they storedrevops/mariadb-drupal-data:__VERSION__.Before / After
Changes
.circleci/config.yml-VORTEX_DB_IMAGE_BASEin thedatabase-nightlyjob..vortex/tests/update-test-assets-SEED_URLandSEED_SHA256move to the26.10.0asset together.Verification
Nothing was published: seeding pushed to a throwaway local registry, and the seeded images were only tagged locally.
26.10.0is upstream commit15685d12, 1 commit past0a357719, the:canarybuild the end-to-end test ran against. That commit changesseed.sh, its tests and docs, but not theDockerfileorentrypoint.bash, and/lagoon/entrypoints/9999-mariadb-init.bashand/etc/mysql/my.cnfare byte-identical in the26.10.0image (sha256:d76f8ffe...) and the canary build (sha256:6fcdfa9e...).drupaldatabase fromdrevops/vortex-dev-mariadb-drupal-data-test-11.x:1.40.0was re-seeded withBASE_IMAGE=drevops/mariadb-drupal-data:canary, andtestAhoyWorkflowDatabaseFromImageStorageInImagepassed against the result:OK (1 test, 401 assertions). It coversahoy buildfrom the image,ahoy reload-db,drush updb,ahoy export-dbinto a.tarand the Behat smoke tests. The export step is the one the relocated.my.cnfaffects:vortex-export-db-imagerunsmysql -eandmariadb-upgrade --forceinside the container with no credentials.26.10.0seed.shasset andBASE_IMAGE=drevops/mariadb-drupal-data:26.10.0, and all 3 stages passed. The untagged destinationlocalhost:5055/...was reported as...:latest, and the run ended on the pushed reference rather than a Docker Hub link.SEED_URLserves a file matchingSEED_SHA256, byte-identical toseed.shat the26.10.0tag.ahoy update-snapshots: 157/157 scenarios passed, 0 fixtures updated.Left alone
update-test-assetspasses noBASE_IMAGE, soseed.shseeds ontodrevops/mariadb-drupal-data:latest, which is the same build as26.10.0(sha256:d76f8ffe...).drevops/vortex-dev-mariadb-drupal-data-*test images, which pick up26.10.0the next timeupdate-test-assetsruns.VORTEX_DB_IMAGE_BASEis pulled but never used by thedatabasebuild; that's tracked in 'VORTEX_DB_IMAGE_BASE' is pulled but never used to build the database container #3177.v26.8.1cache key prefixes in the CI configs, which carry the Vortex release version and aren't related to this image.Release notes: https://github.com/drevops/mariadb-drupal-data/releases/tag/26.10.0