Repository navigation
Replaced 'drevops/behat-format-progress-fail' with the Behat core 'inline_failures' option and updated 'behat/behat' to '^3.34.0'. - #3181
Merged
Conversation
…es' option of the Behat 'progress' formatter and updated 'behat/behat' to '^3.34.0'.
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 19 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (24)
📒 Files selected for processing (5)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6ac30302a8e6de258c4b196c--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
AlexSkrypnyk
added
the
Needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behat now uses its core
progressformatter withinline_failures: trueunderformatters.progressinbehat.yml, so each failed, pending or undefined step prints inline as it happens, inahoy test-bddand in the CI Behat runs alike. Thedrevops/behat-format-progress-failextension, which printed only failed steps inline, is gone fromcomposer.json,behat.ymland the Behat tool entry in the installer'sTools.php.drevops/behat-format-progress-fail1.5.2 declares aconflictonbehat/behat >=3.33, so requiring it at^1.5.2next tobehat/behat ^3.33or newer fails with "Your requirements could not be resolved", and the build and lint jobs stop at theBuild stackstep. The existing^1.5.1pin only kept installing because Composer could fall back to 1.5.1, and Behat 3.33.0 is the release that addedinline_failures, so the package no longer fills a gap.After merge, a failed step prints under
--- FAILED ---instead of--- FAIL ---, and a pending or undefined step gets its own inline block instead of aPorUmarker. Nothing in the repo matches on the old banner, andshow_outputstays unset because both formatters default it toin-summary. The recordedbuildvideo (.vortex/docs/static/img/build.jsonandbuild.svg) still shows the old package in its captured Composer output until the videos are regenerated. Behat 4.0.0 stays out of reach becausedrevops/behat-steps3.14.4 declares aconflictonbehat/behat >=4, which makes^3.34.0the newest usable Behat.Before / After
Composer resolution of the Behat packages:
Behat configuration:
Behat output:
Changes
Behat and Composer
composer.json- removesdrevops/behat-format-progress-failand raisesbehat/behatfrom^3.33.0to^3.34.0.behat.yml- replaces theprogress_fail: trueformatter withprogressandinline_failures: true, and removes theDrevOps\BehatFormatProgressFail\FormatExtensionextension entry. Behat's config tree turns theprogressformatter on by itself when its map has noenabledkey. The comment above the formatter also loses itswhuletypo.Installer
.vortex/installer/src/Prompts/Handlers/Tools.php- the Behat tool entry no longer looks fordrevops/behat-format-progress-failincomposer.jsonwhen it decides whether Behat is present, and its removal callback no longer callsremoveSubNode()for the package..vortex/installer/tests/Fixtures/handler_process/- 24 files across 21 datasets, regenerated withahoy update-snapshots._baselineholds full copies of the files, so_baseline/behat.ymland_baseline/composer.jsoncarry the real content changes. The other 20 datasets hold diffs against it, so most of them only see hunk offsets move by 1 line. The 5 datasets that remove Behat (tools_no_behat,tools_none,tools_groups_no_be_tests, and the_circlecivariants oftools_no_behatandtools_groups_no_be_tests) also lose the-line for the package, because the baseline no longer has it to remove.Documentation
.vortex/docs/content/development/composer.mdx- drops the package row from therequire-devtable..vortex/docs/content/development/testing/behat.mdx- drops the package from the list of contexts and extensions, and rewrites "Output format" to describe theprogressformatter'sinline_failuresoption.Verification
ahoy update-snapshots- a second run passes 157 of 157 scenarios with 0 updates.ahoy --file .vortex/.ahoy.yml lint-installerandahoy --file .vortex/.ahoy.yml lint-docsare clean (Vale reports 0 errors).build (0),build (1)andci/circleci: buildpass with the new formatter config, and all 6vortex-test-workflowshards pass.