utilities: make utils::isBase64 support padding#2472
Merged
an-tao merged 1 commit intodrogonframework:masterfrom Mar 26, 2026
Merged
utilities: make utils::isBase64 support padding#2472an-tao merged 1 commit intodrogonframework:masterfrom
an-tao merged 1 commit intodrogonframework:masterfrom
Conversation
MouhK
force-pushed
the
feature/padding-friendly-is-base64
branch
from
b06dea4 to
a6ca551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following RFC 4648 utils::isBase64 should accept padded encoded data. Current implementation allows URL characters '-, _' so it should also support padding character ('=').
More over with current implementation the following code fails, which doesn't make sense.
std::string in{"drogon framework"}; auto encoded = drogon::utils::base64Encode(in); if (!drogon::utils::isBase64(encoded)) std::cerr << "Not base64" << std::endl;$ output = Not base64