Fix/shared lib view failure handling#2475
Merged
an-tao merged 2 commits intodrogonframework:masterfrom Apr 1, 2026
Merged
Conversation
Member
|
@AzmeerX Thanks for your patch. pls rebase from the master branch. |
Contributor
Author
|
rebasing done. also fixed the formatting issue |
Member
|
Why do file changes show content in the parseLine PR? |
AzmeerX
force-pushed
the
fix/shared-lib-view-failure-handling
branch
from
3652b3f to
06b6de2
Compare
Contributor
Author
Because of incorrect base. I’ve created a clean branch from latest master with only the intended change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper error handling for
drogon_ctl create viewexecution.Previously, the return value of
safeExecwas ignored. If view generation failed, the system would still attempt to compile the generated.ccfile, which could be missing or invalid. This resulted in unnecessary compilation errors and potential use of stale or inconsistent state.Changes
Check return code from
safeExec, Log an error and skip compilation if generation fails. Preserved existing shared library handle instead of proceeding with invalid inputTesting
cd build
make
compiling successfully