lib: fix response header component sanitization#2478
Open
quart27219 wants to merge 1 commit intodrogonframework:masterfrom
Open
lib: fix response header component sanitization#2478quart27219 wants to merge 1 commit intodrogonframework:masterfrom
quart27219 wants to merge 1 commit intodrogonframework:masterfrom
Conversation
Member
|
@quart27219 Thanks so much for your patch, but this PR adds a mandatory check in the hotspot path, which actually increases the program overhead. I think this should be something that application developers need to pay attention to. They should know which addHeader calls are risky and should add such checks. @marty1885 @rbugajewski |
Collaborator
|
@an-tao Yes, I agree. In this case, it would be worthwhile to mention the risks in the corresponding documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2469.
It fixes response header component sanitization by stripping
\r,\n, and\0inHttpResponseImpl::addHeader().This prevents response header injection / splitting when untrusted input is used in response headers.