Skip to content

Replace force cast with safe conditional cast #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcarroll3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace force cast with safe conditional cast #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Source/SwiftyDropbox/Shared/Handwritten/Request.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ public class Request<RSerial: JSONSerializer, ESerial: JSONSerializer> {

func handleResponseError(networkTaskFailure: NetworkTaskFailure) -> CallError<ESerial.ValueType> {
let callError = parseCallError(from: networkTaskFailure)

// We call the global error response handler to alert it to an error
// But unlike in the objc SDK we do not stop the SDK from calling the per-route completion handler as well.
GlobalErrorResponseHandler.shared.reportGlobalError(callError.typeErased)

return callError
}

private func parseCallError(from networkTaskFailure: NetworkTaskFailure) -> CallError<ESerial.ValueType> {
switch networkTaskFailure {
case .badStatusCode(let data, _, let response):
Expand Down Expand Up @@ -292,7 +292,7 @@ public class DownloadRequestMemory<RSerial: JSONSerializer, ESerial: JSONSeriali

private func caseInsensitiveLookup(_ lookupKey: String, dictionary: [AnyHashable: Any]) -> String? {
for key in dictionary.keys {
let keyString = key as! String
guard let keyString = key as? String else { continue }
if keyString.lowercased() == lookupKey.lowercased() {
return dictionary[key] as? String
}
Expand Down
2 changes: 1 addition & 1 deletion Source/SwiftyDropbox/Shared/Handwritten/Utilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Foundation

enum Utilities {
static func utf8Decode(_ data: Data) -> String {
NSString(data: data, encoding: String.Encoding.utf8.rawValue)! as String
String(data: data, encoding: .utf8) ?? String(data: data, encoding: .ascii) ?? ""
}

static func asciiEscape(_ s: String) -> String {
Expand Down
Loading