Skip to content

Fix code and documentation related to Processing Unit Application - #21

Open
imdshr wants to merge 5 commits into
mainfrom
fix_wrong_term_processing_unit_application
Open

Fix code and documentation related to Processing Unit Application#21
imdshr wants to merge 5 commits into
mainfrom
fix_wrong_term_processing_unit_application

Conversation

@imdshr

@imdshr imdshr commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix code and documentation related to Processing Unit Application handling:

  • Rename add_application_processing_unit to add_processing_unit_application and move it from hardware related module to application management related module.
  • Improve description of add_processing_unit_application.

Validation

  • uv run ruff check .
  • uv run ruff format --check .
  • uv run pytest ConfigurationDeskMCP/tests
  • uv run configurationdesk-mcp --list-tools
  • Documentation and tool specifications are updated when applicable.
  • No credentials, local paths, proprietary assets, or generated artifacts were added.

@imdshr
imdshr requested a review from IZacharias September 3, 2026 13:29
@imdshr
imdshr requested a review from Akshay-r-rao as a code owner September 3, 2026 13:29
Comment thread configurationdesk_com_bridge/domains/app_management_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/app_management_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/app_management_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/app_management_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/hardware_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/hardware_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/hardware_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/hardware_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/hardware_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/app_management_com.py Outdated
Comment thread configurationdesk_com_bridge/domains/model_topology_com.py Outdated
Comment thread ConfigurationDeskMCP/sources/prompts/configurationdesk_prompts.py Outdated
Comment thread ConfigurationDeskMCP/sources/prompts/configurationdesk_prompts.py Outdated
Comment on lines 260 to +261
A ProcessingUnitApplication must exist: register a hardware platform
(`add_hardware_platform`) or, for VEOS/no-hardware, call `add_application_processing_unit`.
(`add_hardware_platform`) or, for VEOS/no-hardware, call `add_processing_unit_application`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. Registering a hardware platform has nothing to do with a processing unit application.
At least one processing unit application is mandatory for a ConfigurationDesk application regardless of whether a real-time application shall be created or a BSC.

Would be nice if this prerequisite would not be necessary, and that instead the create_application_process would automatically create a processing unit application if no processing unit application exists.

@mcp.prompt(
name="register_hardware",
description="Single task: provide the hardware topology — register a SCALEXIO/MicroAutoBox III/MicroLabBox II platform, import an .htfx file, or add a VEOS processing unit",
description="Single task: provide the hardware topology — register a SCALEXIO/MicroAutoBox III/MicroLabBox II platform, import an .htfx file, or add a processing unit application for VEOS",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the "or add a processing unit application". You might add something like "Registering a hardware is not necessary if you want to create a Bus simulation container (BSC)"

The runtime schema for `build_application` accepts `download`, `start`, and
`unload`. Use `download=false` when hardware download is not wanted.

The build generates one real-time application per processing unit application,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not correct. ConfigurationDesk creates one real-time application with 1..n processing unit applications. Each processing unit application runs on one processing unit. An application with 2..n processing unit application is a multi-processing-unit application that can run on a multi-processing-unit system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants