Skip to content

fix: Address command-line parsing issue with trailing backslashes in … - #444

Merged
carstencodes merged 3 commits into
mainfrom
fix/trailing-backslash-cmdline-args
Jul 16, 2026
Merged

fix: Address command-line parsing issue with trailing backslashes in …#444
carstencodes merged 3 commits into
mainfrom
fix/trailing-backslash-cmdline-args

Conversation

@matthiasnissen

@matthiasnissen matthiasnissen commented Jul 15, 2026

Copy link
Copy Markdown
Member

Before embedding each path into a quoted command-line argument, strip or escape a trailing backslash so it no longer immediately precedes the closing quote. For example, doubling a lone trailing backslash (" → \") makes the Windows argv parser emit a single literal backslash and correctly close the quoted argument.

@carstencodes

Copy link
Copy Markdown
Member

As this may conflict with #442 , should we change the target branch its source branch?

@matthiasnissen

Copy link
Copy Markdown
Member Author

@carstencodes: I will just wait for #442 to get merged and than rework my fix...

@matthiasnissen

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

…h-cmdline-args

# Conflicts:
#	src/dscom.build/dSPACE.Runtime.InteropServices.BuildTasks.Tools.targets

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merged main (which includes #442) into this branch. The conflict in dSPACE.Runtime.InteropServices.BuildTasks.Tools.targets was resolved as follows:

Merge commit: 3679e41

@matthiasnissen

Copy link
Copy Markdown
Member Author

@carstencodes Could you do another review?

@carstencodes carstencodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@carstencodes
carstencodes merged commit d617a78 into main Jul 16, 2026
5 checks passed
@carstencodes
carstencodes deleted the fix/trailing-backslash-cmdline-args branch July 16, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange behavior of dscom when adding --asmpath containing a backslash in MsBuild Exec task

3 participants