Skip to content

Remove deprecated license classifier#267

Merged
randomir merged 1 commit intodwavesystems:mainfrom
thisac:fix/license-classifier
Apr 9, 2026
Merged

Remove deprecated license classifier#267
randomir merged 1 commit intodwavesystems:mainfrom
thisac:fix/license-classifier

Conversation

@thisac
Copy link
Copy Markdown
Contributor

@thisac thisac commented Apr 8, 2026

Setuptools>=77 now raises

setuptools.errors.InvalidConfigError: License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/). Please remove:

      License :: OSI Approved :: Apache Software License

since its deprecation. See PEP 639 and #4833 for details.

@thisac thisac requested a review from randomir April 8, 2026 15:56
Copy link
Copy Markdown
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But the new setuptools behavior screams bug to me! Zero grace period / deprecation period -- but immediate build error! The PEP says the tools MAY raise an error.. So the better approach would be they first raised a warning, then turned it into an error...

@randomir randomir merged commit 6c611d0 into dwavesystems:main Apr 9, 2026
18 checks passed
@thisac
Copy link
Copy Markdown
Contributor Author

thisac commented Apr 9, 2026

So the better approach would be they first raised a warning, then turned it into an error...

Completely agree with that! Also understood it as optional, but the error is there and this fix isn't really intrusive. 🫤

@randomir
Copy link
Copy Markdown
Member

randomir commented Apr 9, 2026

So the better approach would be they first raised a warning, then turned it into an error...

Completely agree with that! Also understood it as optional, but the error is there and this fix isn't really intrusive. 🫤

Also, they only raise a warning under the same conditions if the config is in setup.cfg/setup.py:

SetuptoolsDeprecationWarning: License classifiers are deprecated.

and raise an error if pyproject.toml is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants