define forgotten ne

[sroet]

while working on #115 , a test started failing with:

_______________________________ TestMutableContactTrajectory.test_hash_eq _______________________________

self = <contact_map.tests.test_contact_trajectory.TestMutableContactTrajectory object at 0x7fca5ea18dc0>

    def test_hash_eq(self):
        cmap = MutableContactTrajectory(self.traj, cutoff=0.075,
                                        n_neighbors_ignored=0)
        assert hash(cmap) != hash(self.map)
>       assert cmap != self.map
E       assert <contact_map.contact_trajectory.MutableContactTrajectory object at 0x7fca5ed678b0> != <contact_map.contact_trajectory.MutableContactTrajectory object at 0x7fca5eaa5850>
E        +  where <contact_map.contact_trajectory.MutableContactTrajectory object at 0x7fca5eaa5850> = <contact_map.tests.test_contact_trajectory.TestMutableContactTrajectory object at 0x7fca5ea18dc0>.map

contact_map/tests/test_contact_trajectory.py:222: AssertionError

Which was due to the fact the ContactTrajectory did update __eq__, but not __ne__. This fixes that oversight

[dwhswenson]

Huh... I thought that __ne__ wasn't necessary in Python 3 (and we're not-intentionally-breaking-but-not-supporting Python 2). From https://docs.python.org/3/reference/datamodel.html#object.__ne__:

For __ne__(), by default it delegates to __eq__() and inverts the result unless it is NotImplemented.

Does Cython not follow that?

Either way, I have no problem with adding the extra __ne__ method. Doesn't hurt anything. Will merge when AppVeyor finishes.

[codecov]

Codecov Report

Merging #116 (11da8b4) into master (bcff7ce) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1125      1127    +2     
=========================================
+ Hits          1125      1127    +2     

Impacted Files	Coverage Δ
contact_map/contact_trajectory.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcff7ce...11da8b4. Read the comment docs.

[sroet]

Does Cython not follow that?

So inheritance of compiled cython code into python is a bit special 😅
(Tested this by adding a quick print statement to the ContactObject.__eq__. )
It seems that __ne__ is inherited from ContactObject, but this is compiled in c as not ContactObject.__eq__ 😅