Skip to content
This repository was archived by the owner on Aug 17, 2021. It is now read-only.

set rewritePrefix to true#129

Open
tatchi wants to merge 4 commits into
masterfrom
rewritePrefix-true
Open

set rewritePrefix to true#129
tatchi wants to merge 4 commits into
masterfrom
rewritePrefix-true

Conversation

@tatchi

@tatchi tatchi commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator

Close #128. Let's see if CI passes

@tatchi

tatchi commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator Author

@ManasJayanth Any idea what might go wrong here?

@ManasJayanth

Copy link
Copy Markdown
Contributor

Couple of things

  1. The postinstall.js isn't identical to the one esy creates on running the release command. On Windows, it was incorrectly trying set the env variable

  2. The path where node_modules is installed is too deep - possible to configure the project root to shallower?

@ManasJayanth ManasJayanth mentioned this pull request Oct 30, 2020
@tatchi tatchi force-pushed the rewritePrefix-true branch from 1b63bc2 to 82188b2 Compare November 1, 2020 10:11
@tatchi tatchi force-pushed the rewritePrefix-true branch from 82188b2 to 6bced13 Compare November 1, 2020 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use current version of esy in CI

2 participants