-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Added Davis Analyzers #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Package.json Changes DetectedThis PR modifies Checklist for Reviewers
Package.json Diffdiff --git a/package.json b/package.json
index 7751ddf..c2e24c7 100644
--- a/package.json
+++ b/package.json
@@ -48,6 +48,7 @@
"license": "MIT",
"dependencies": {
"@dynatrace-sdk/client-automation": "^5.3.0",
+ "@dynatrace-sdk/client-davis-analyzers": "^1.9.8",
"@dynatrace-sdk/client-davis-copilot": "^1.0.0",
"@dynatrace-sdk/client-platform-management-service": "^1.6.3",
"@dynatrace-sdk/client-query": "^1.18.1",
This comment was automatically generated by the PR Package.json Comment workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Davis Analyzers to the Dynatrace MCP Server, enabling users to list and execute various types of analyzers (forecast, anomaly detection, correlation) programmatically.
Key changes:
- Introduces two new tools:
list_davis_analyzersandexecute_davis_analyzer - Adds required OAuth scopes for Davis Analyzer operations
- Implements a polling mechanism for long-running analyzer executions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Adds import for Davis Analyzer capabilities, registers two new tools, and includes required OAuth scopes |
| src/capabilities/davis-analyzers.ts | Implements core Davis Analyzer functionality including listing and execution with polling support |
| package.json | Adds dependency on @dynatrace-sdk/client-davis-analyzers version ^1.9.7 |
| package-lock.json | Updates lock file with resolved version 1.9.8 of the Davis Analyzers client |
| README.md | Documents the two new OAuth scopes required for Davis Analyzer functionality |
| CHANGELOG.md | Documents the new tools and scopes in the Unreleased Changes section |
408f238 to
12412fe
Compare
d9e6fbc to
2a40111
Compare
2a40111 to
6cde7b0
Compare
MrManny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only concern is overdocumenting. I flagged one instance, but I see a few others as well, e.g.:
/**
* Execute a Davis Analyzer
*/
export async function executeDavisAnalyzer(Feels a bit redundant, since the function name already says exactly what it does and the comment adds nothing on top of it. What are your thoughts?
6cde7b0 to
966bf80
Compare
chore: added integration-tests for davis analyzers chore: Improve implementation
966bf80 to
7fb5c21
Compare
Added Davis Analyzer tools. To try it out, I did the following prompts:
followed by
and followed by
which lead to
list_davis_analyzersandexecute_davis_analyzerbeing executed :)Alternatively, all in one prompt: