Skip to content

Conversation

@joewiz
Copy link
Member

@joewiz joewiz commented May 19, 2019

DO NOT MERGE until #342 is merged. This is actually based off of that branch.

Update (2018-05-22): #342 was superseded by #349 (the 5.0.0-RC1 branch), so I rebased against it instead.

@joewiz
Copy link
Member Author

joewiz commented May 19, 2019

I found a few URLs that still have problems:

[
    {
        "404-errors": [
            {"backup.xml": "http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/tutorial-lesson-06.html"},
            {"beginners-guide-to-xrx-v4.xml": "http://localhost:8080/exist/apps/term/index.html"},
            {"scheduler.xml": "http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html"},
            {
                "devguide_indexes.xml": [
                    "http://www.ordnancesurvey.co.uk/oswebsite/products/try-now/sample-data.html",
                    "http://www.vividsolutions.com/jts/bin/JTS%20Technical%20Specs.pdf",
                    "http://www.ordnancesurvey.co.uk/products/osmastermap/layers/topography/sampledata/2182-SS7886-2c1.gz",
                    "http://www.vividsolutions.com/jts/jtshome.htm"
                ]
            }
        ]
    },
    {
        "other-error": [
            {
                "deployment.xml": {
                    "error": "titanium.dstc.edu.au: nodename nor servname provided, or not known",
                    "href": "http://titanium.dstc.edu.au"
                }
            },
            {
                "xforms.xml": [
                    {
                        "error": "Connect to www.betterform.de:80 [www.betterform.de/212.204.63.100] failed: Operation timed out (Connection timed out)",
                        "href": "http://www.betterform.de"
                    },
                    {
                        "error": "Connect to betterform.de:80 [betterform.de/212.204.63.100] failed: Operation timed out (Connection timed out)",
                        "href": "http://betterform.de/trac"
                    },
                    {
                        "error": "Connect to betterform.de:80 [betterform.de/212.204.63.100] failed: Operation timed out (Connection timed out)",
                        "href": "http://betterform.de"
                    },
                    {
                        "error": "Connect to betterform.de:80 [betterform.de/212.204.63.100] failed: Operation timed out (Connection timed out)",
                        "href": "http://betterform.de/reports/Firefox-3.0-Mac-OS-X-10.6-ConformanceReport1.1.html",
                        "doc": "xforms.xml"
                    }
                ]
            },
            {
                "devguide_indexes.xml": [
                    {
                        "error": "geotools.codehaus.org: nodename nor servname provided, or not known",
                        "href": "http://geotools.codehaus.org/"
                    },
                    {
                        "error": "lists.refractions.net: nodename nor servname provided, or not known",
                        "href": "http://lists.refractions.net/m2/org/geotools/gt2-epsg-hsql/"
                    },
                    {
                        "error": "javadoc.geotools.fr: nodename nor servname provided, or not known",
                        "href": "http://javadoc.geotools.fr/snapshot/org/geotools/referencing/factory/epsg/FactoryOnHSQL.html"
                    }
                ]
            }
        ]
    }
]

Suggestions welcome!

@duncdrum duncdrum requested a review from a team May 19, 2019 08:31
@duncdrum duncdrum added this to the 5.0.0 milestone May 19, 2019
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe these are very helpful. Since these are based of the maven changes, these can only go into v5 of the docs, however we have at least one more v4 release scheduled.

I'd be happy to merge a cherry-picked branch of just the non-maven stuff preferably after #343 is in. Where we could then also add a link checker to the XQsuite tests.

@joewiz
Copy link
Member Author

joewiz commented May 19, 2019

@duncdrum Great to hear. Sure, cherry pick away.

@joewiz joewiz changed the base branch from master to 5.0.0-RC1 May 22, 2019 17:48
joewiz added 8 commits May 22, 2019 13:52
- Move Author Reference to other documentation administration
- Correct link to CONTRIBUTIING.md
- Grammar
- Reduce phrases like “This article will tell you how to…” or “Provides you with information about how to” to “How to…”
From author guidelines: “use the target's document name (without the .xml extension) as the link address.”
and miscellaneous catches
@joewiz
Copy link
Member Author

joewiz commented May 22, 2019

Rebased against 5.0.0-RC1 branch.

@adamretter
Copy link
Contributor

@joewiz @duncdrum Should I merge this, or some magic is still happening elsewhere?

@duncdrum
Copy link
Contributor

lets fix the failing CI first

@joewiz
Copy link
Member Author

joewiz commented May 22, 2019

@duncdrum Thanks for the nudge - I forgot to run mvn test...

@duncdrum duncdrum merged commit 4c2ed83 into eXist-db:5.0.0-RC1 May 22, 2019
@joewiz joewiz deleted the review-links branch May 22, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants