test: isolate deprecation unit test from live NASA URS calls#1370
Open
mvanhorn wants to merge 1 commit into
Open
test: isolate deprecation unit test from live NASA URS calls#1370mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
|
I will automatically update this comment whenever this PR is modified |
2 tasks
Sherwin-14
approved these changes
Jun 27, 2026
Sherwin-14
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mvanhorn! This looks so much cleaner now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tests/unit/test_deprecations.pymade real network calls to NASA's URS login endpoint. Itsauthfixture mocked the URS calls only while constructing the auth object, but theresponsescontext exited before the test body ran, soearthaccess.login(...)andStore(auth)inside the test reached the live service. That makes a "unit" test depend on network access and valid credentials, so it fails or hangs in offline/CI sandboxes.This keeps the mocked URS responses active for the whole test by making the
authfixtureyieldfrom inside a function-scopedresponses.RequestsMockcontext. Every request on the login/Store path is now served by the mock, and any unmocked request is blocked rather than sent to NASA. The test's assertions are unchanged; only its network isolation is fixed. No production code changes.resolves #1321
"Ready for review" checklist
Merge checklist
closes #1)CHANGELOG.mdupdated (not needed — test-only change, no user-facing behavior change)README.mdupdated (not needed)pre-commit.ci autofixif pre-commit is failing) (pytest tests/unit/test_deprecations.pypasses locally with no network)📚 Documentation preview 📚: https://earthaccess--1370.org.readthedocs.build/en/1370/