Honor sanity_check_commands & sanity_check_paths from extensions
#5012
+106
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
from
8743828 to
5943e1d
Compare
Open
3 tasks
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
2 times, most recently
from
e1fd987 to
4b556af
Compare
Member
|
I would really like to see #5015 merged first so we can more easily review this... |
This now calls the inherited `EasyBlock.sanity_check_step` that handles the `sanity_check_commands` & `sanity_check_paths` for extensions too.
It is redundant as `self.is_extension` provides that information already.
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
from
f4b578f to
18417ad
Compare
Contributor
Author
|
Rebased after merge of that PR |
boegel
reviewed
Dec 3, 2025
| '6.0', | ||
| ) | ||
| if extension != self.is_extension: | ||
| raise EasyBuildError('Unexpected value for `extension` argument. ' |
Member
There was a problem hiding this comment.
This isn't exactly ignoring it, as is stated above...
What's the point of raising an error for an incorrect value being passed that's going to be ignored?!
Contributor
Author
There was a problem hiding this comment.
Because if we have different values it is an error somewhere.
So a) it doesn't need to be passed but b) if it is it should match the expected value
We can remove that check in EB 6 but I'd better play it safe until then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently those are silently ignored leading to success where it should fail.
The only official easyconfig affected by this so far is
MDAnalysis-2.4.2-foss-2021a.ebbut I ran into this while creating an easyconfigIncludes
saved_envcontext manager for restoring environment in tests #5015