also pick up on toolchain components in Toolchain._add_dependency_variables
#5042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly determined
…s of toolchain components like OpenMPI
This was referenced Nov 13, 2025
boegel
commented
Nov 13, 2025
| if dep.get("external_module", False): | ||
| # collect software install prefixes for toolchain components + dependencies | ||
| dep_roots = [] | ||
| for dep in deps + self.tcdeps: |
Member
Author
There was a problem hiding this comment.
Just to point it out: here's the actual fix.
Everything else that was changed in easybuild/* is basically (very minor) code style improvement...
Contributor
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this pull request
Nov 14, 2025
In easybuilders#5042 `tcdeps` is actually used to get the software roots. Those are only available for *runtime* dependencies of the toolchain module. So it will fail for build dependencies which are however included by EasyConfig.toolchain.
boegel
deleted the
fix_toolchain_add_dependency_variables_toolchain_components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #5041 (which was a follow-up for #5023) to fix another problem when using
--search-path-cpp-headers=include_paths, as we're doing in EESSI.Without this, the configure step for `` (see ) fails with:
config.logshows: