Don't append empty component to start_dir in EasyBlock.guess_start_dir
#5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
start_dir_slash
branch
2 times, most recently
from
7f1447f to
9d7adab
Compare
In most cases `start_dir` is unset/empty. When passing it to `os.path.join` it leads to `/topdir/` which could cause issues when using the template as `%(startdir)s/subdir` as a double-slash might be treated specially.
Flamefire
force-pushed
the
start_dir_slash
branch
from
d3e3184 to
5e8b0ee
Compare
boegel
changed the title
EasyBlock.guess_start_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases
start_diris unset/empty.When passing it to
os.path.joinit leads to/topdir/which could cause issues when using the template as%(startdir)s/subdiras a double-slash might be treated specially.