[Test] Automate rename workspace test#23838
Merged
Merged
Conversation
Contributor
|
@SkorikSergey, did you have a run |
dmytro-ndp
reviewed
May 8, 2026
| /** | ||
| * devSpaces Dashboard does not allow editing the workspace display name while the workspace is running. | ||
| */ | ||
| async waitRenameWorkspaceNotPossibleWhileWorkspaceRunning(): Promise<void> { |
Contributor
There was a problem hiding this comment.
I would suggest making the method name more specific, like checkRenameButtonIsAbsent()
dmytro-ndp
reviewed
May 8, 2026
dmytro-ndp
reviewed
May 8, 2026
| await this.waitWorkspaceTitle(newDisplayName); | ||
| } | ||
|
|
||
| async attemptRenameWorkspaceName(desiredName: string): Promise<void> { |
Contributor
There was a problem hiding this comment.
attemptRenameWorkspaceName() is really test-level assertion logic - it's verifying a negative scenario (save button disabled, then cancel). That kind of logic belongs in the spec file (RenameWorkspace test), not in the page object.
dmytro-ndp
reviewed
May 8, 2026
Contributor
Author
Yes, I will update PR description with logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Automate “Rename Workspace” test
Test scenario:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-10665
How to test this PR?
Test logs
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.