Prevent deadlock during Plexus container creation - #2217
Open
TyceHerrman wants to merge 1 commit into
Open
Conversation
TyceHerrman
force-pushed
the
agent/prevent-plexus-container-creation-deadlock
branch
from
August 5, 2026 01:04
52f00c5 to
823c223
Compare
TyceHerrman
marked this pull request as ready for review
August 5, 2026 01:32
Test Results 348 files + 3 348 suites +3 1h 11m 2s ⏱️ + 5m 1s For more details on these failures, see this check. Results for commit d27ece6. ± Comparison against base commit f82726e. ♻️ This comment has been updated with latest results. |
TyceHerrman
force-pushed
the
agent/prevent-plexus-container-creation-deadlock
branch
from
August 20, 2026 03:23
823c223 to
d27ece6
Compare
TyceHerrman
force-pushed
the
agent/prevent-plexus-container-creation-deadlock
branch
from
August 24, 2026 23:20
d27ece6 to
8122b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
org.eclipse.m2e.corequalifier update because the bundle version was already bumped this release cycleWhy
Container construction can enter Maven settings code while Maven settings processing can acquire a Plexus container. Holding the container cache monitor during construction creates a lock-order inversion and can deadlock Eclipse startup.
The new coordination keeps at most one creator for each Maven root without holding the manager lock across Maven/Plexus calls.
Fixes #1749.
Fixes #2008.
Verification
PlexusContainerManagerTest: 5 tests, 0 failures, 0 errorsorg.eclipse.m2e.core.tests: 29 tests, 0 failures, 0 errors, 1 skippedmvn clean verifyreached all 46 modules; production bundles and repository passed, but Cocoa UI test processes abort on macOS 27 beta inSwiftNativeNSArray.swift:78withArray index out of rangegit diff --check upstream/main...HEADThe local CBI macOS signing attempts also return the expected nonfatal 403 outside Eclipse infrastructure.