Skip to content

Enable if pattern simplification and disable requireNonNull simplifications of CFG simplifier #22838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enable if pattern simplification and disable requireNonNull simplifications of CFG simplifier #22838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65701fd
Disable requireNonNull simplifications
hzongaro Oct 21, 2025
e2ae920
Enable if pattern simplification in CFG Simplification
hzongaro Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions runtime/compiler/optimizer/J9CFGSimplifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@

bool J9::CFGSimplifier::simplifyIfPatterns(bool needToDuplicateTree)
{
static char *enableCFGSimplification = feGetEnv("TR_enableCFGSimplificaiton");
if (enableCFGSimplification == NULL)
static const char *disableCFGSimplification = feGetEnv("TR_disableCFGSimplification");
if (disableCFGSimplification != NULL)
return false;

return OMR::CFGSimplifier::simplifyIfPatterns(needToDuplicateTree)
Expand Down Expand Up @@ -71,9 +71,9 @@ bool J9::CFGSimplifier::simplifyIfPatterns(bool needToDuplicateTree)

bool J9::CFGSimplifier::simplifyUnresolvedRequireNonNull(bool needToDuplicateTree)
{
static char *disableSimplifyExplicitNULLTest = feGetEnv("TR_disableSimplifyExplicitNULLTest");
static char *disableSimplifyUnresolvedRequireNonNull = feGetEnv("TR_disableSimplifyUnresolvedRequireNonNull");
if (disableSimplifyExplicitNULLTest != NULL || disableSimplifyUnresolvedRequireNonNull != NULL)
static const char *enableSimplifyExplicitNULLTest = feGetEnv("TR_enableSimplifyExplicitNULLTest");
static const char *enableSimplifyUnresolvedRequireNonNull = feGetEnv("TR_enableSimplifyUnresolvedRequireNonNull");
if (enableSimplifyExplicitNULLTest == NULL || enableSimplifyUnresolvedRequireNonNull == NULL)
return false;

if (comp()->getOSRMode() == TR::involuntaryOSR)
Expand Down Expand Up @@ -242,9 +242,9 @@ bool J9::CFGSimplifier::simplifyUnresolvedRequireNonNull(bool needToDuplicateTre
//
bool J9::CFGSimplifier::simplifyResolvedRequireNonNull(bool needToDuplicateTree)
{
static char *disableSimplifyExplicitNULLTest = feGetEnv("TR_disableSimplifyExplicitNULLTest");
static char *disableSimplifyResolvedRequireNonNull = feGetEnv("TR_disableSimplifyResolvedRequireNonNull");
if (disableSimplifyExplicitNULLTest != NULL || disableSimplifyResolvedRequireNonNull != NULL)
static const char *enableSimplifyExplicitNULLTest = feGetEnv("TR_enableSimplifyExplicitNULLTest");
static const char *enableSimplifyResolvedRequireNonNull = feGetEnv("TR_enableSimplifyResolvedRequireNonNull");
if (enableSimplifyExplicitNULLTest == NULL || enableSimplifyResolvedRequireNonNull == NULL)
return false;

if (comp()->getOSRMode() == TR::involuntaryOSR)
Expand Down