Check stack map if type changed in the exception table range #22889
+51
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
fix_22812
branch
6 times, most recently
from
e60570d to
8961174
Compare
theresa-m
changed the title
theresa-m
force-pushed
the
fix_22812
branch
4 times, most recently
from
15f4e78 to
029331c
Compare
Contributor
Author
|
@tajila this is ready for review. |
Member
|
This has a conflict. |
Signed-off-by: Theresa Mammarella <[email protected]>
Contributor
Author
Fixed. |
J9 has been validating the type state for exceptions after astore changes the type. This is incorrect since according to JVMS 4.10.1.4 the state of a stack map frame is the incoming state of an instruction. This means that the type state of astore is the state before the new local is set. Instead only compare the type state for exceptions if astore changes the type state and another bytecode within the range of the exception exists to make sure its still compatible. Signed-off-by: Theresa Mammarella <[email protected]>
babsingh
approved these changes
Nov 13, 2025
Contributor
|
jenkins test sanity.functional,sanity.openjdk zlinux jdk8 |
Contributor
|
jenkins test sanity.functional,sanity.openjdk amac jdk21,jdk25 |
Contributor
|
jenkins test sanity.functional,sanity.openjdk plinux jdk17 |
Contributor
|
jenkins compile win jdk11 |
gacholio
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J9 has been validating the type state for exceptions after astore
changes the type. This is incorrect since according to JVMS
4.10.1.4 the state of a stack map frame is the incoming state
of an instruction. This means that the type state of astore is
the state before the new local is set.
Instead only compare the type state for exceptions if astore
changes the type state and another bytecode within the range
of the exception exists to make sure its still compatible.
Fixes: #22812
Internal tests:
Java 25: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/56075
Java 11: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/56076/
IBM Java 8: http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=105944