Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Jan 6, 2026

Migrate performance tests to JUnit 5 to avoid dependency on PerformanceTestCaseJunit4.

  • Update UIPerformanceTestRule to implement BeforeAllCallback and AfterAllCallback.
  • Migrate GenerateIdentifiersTest and LabelProviderTest to use PerformanceMeter directly.
  • Use CloseTestWindowsExtension instead of CloseTestWindowsRule.
  • Add necessary JUnit 5 imports to MANIFEST.MF.

This is part of the work for issue #3639.

Replace the usage of ".java" extension with a custom ".perf_text" extension in performance tests.
The use of ".java" caused the OS to open external editors/terminals in environments where JDT is not installed or configured as the default editor.
This change ensures that an internal test editor is used, keeping the tests self-contained and preventing external side effects.
Migrate performance tests to JUnit 5 to avoid dependency on PerformanceTestCaseJunit4.
- Update UIPerformanceTestRule to implement BeforeAllCallback and AfterAllCallback.
- Migrate GenerateIdentifiersTest and LabelProviderTest to use PerformanceMeter directly.
- Use CloseTestWindowsExtension instead of CloseTestWindowsRule.
- Add necessary JUnit 5 imports to MANIFEST.MF.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Test Results

 3 015 files  + 9   3 015 suites  +9   2h 17m 56s ⏱️ + 3m 8s
 8 258 tests ± 0   8 010 ✅ ± 0  248 💤 ±0  0 ❌ ±0 
23 598 runs  +26  22 807 ✅ +23  791 💤 +3  0 ❌ ±0 

Results for commit fd4ffba. ± Comparison against base commit 88e2b87.

♻️ This comment has been updated with latest results.

Migrate ComputeSizeTest, LayoutTest, and ResizeTest to JUnit 5.
- Introduce LayoutPerformanceTestSuite for shared data providers.
- Remove inheritance from PerformanceTestCaseJunit4.
- Use CloseTestWindowsExtension.
- Use PerformanceMeter directly.
- Ensure INTRO_VIEW in UIPerformanceTestRule is visible.
@vogella
Copy link
Contributor Author

vogella commented Jan 7, 2026

Fixed the unused flushState parameter warning in ComputeSizeTest.java

1 similar comment
@vogella
Copy link
Contributor Author

vogella commented Jan 7, 2026

Fixed the unused flushState parameter warning in ComputeSizeTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant