Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

  • add further assertions for the number of affected resources
  • make MarkersChangeListener.assertChange() wait for asynchronously processed change events to avoid race conditions

Addresses race condition seen as test failure testMarkerDeltasMoveFile(TestInfo) (AutomatedResourceTests AllResourcesTests MarkerTest) in this test run: https://github.com/eclipse-platform/eclipse.platform/pull/2396/checks?check_run_id=59405642125

[number of markers for resource /MyProject/folder/subFile.txt] 
expected: 2
 but was: 1
org.opentest4j.AssertionFailedError: 
[number of markers for resource /MyProject/folder/subFile.txt] 
expected: 2
 but was: 1
	at org.eclipse.core.tests.resources.MarkersChangeListener.assertChanges(MarkersChangeListener.java:54)
	at org.eclipse.core.tests.resources.MarkerTest.testMarkerDeltasMoveFile(MarkerTest.java:977)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

- add further assertions for the number of affected resources
- make MarkersChangeListener.assertChange() wait for asynchronously
processed change events to avoid race conditions
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Test Results

 1 956 files  +1 304   1 956 suites  +1 304   1h 36m 37s ⏱️ + 57m 12s
 4 743 tests ±    0   4 719 ✅ +   31   24 💤  -  31  0 ❌ ±0 
14 229 runs  +9 486  14 047 ✅ +9 359  182 💤 +127  0 ❌ ±0 

Results for commit 211ed2c. ± Comparison against base commit 690721b.

@HeikoKlare HeikoKlare merged commit fd94e7c into eclipse-platform:master Jan 4, 2026
18 checks passed
@HeikoKlare HeikoKlare deleted the MarkerTests-racecondition branch January 4, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant