move content of log_rust to /score/mw/log/rust + adoptions due to process - #390
Open
arsibo wants to merge 4 commits into
Open
move content of log_rust to /score/mw/log/rust + adoptions due to process#390arsibo wants to merge 4 commits into
arsibo wants to merge 4 commits into
Conversation
Move all Rust logging components from score/log_rust/ to score/mw/log/rust/ to co-locate them with the C++ logging implementation under score/mw/log/. - Relocate score_log, score_log_fmt, score_log_fmt_macro, stdout_logger, stdout_logger_cpp_init to score/mw/log/rust/ - Update all Bazel labels (//score/log_rust/... -> //score/mw/log/rust/...) and Cargo.toml workspace paths accordingly - Add deprecated alias BUILD files in score/log_rust/ for backward compatibility (score_log, stdout_logger, stdout_logger_cpp_init) - Update existing deprecated aliases in src/log/ to point directly to the new //score/mw/log/rust/ location
arsibo
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
July 16, 2026 15:20
arsibo
requested a deployment
to
workflow-approval
July 16, 2026 15:20 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
arsibo
requested a deployment
to
workflow-approval
July 16, 2026 15:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
Member
|
@arkjedrz, @rmaddikery, can you please have a look? |
arkjedrz
reviewed
Jul 21, 2026
arkjedrz
left a comment
arkjedrz
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, but it was also discussed that rust/cpp subdirectory should be used when a component offers secondary interface to another language (library X written in C++ provides Rust interface -> X/rust, library Y written in Rust provides C++ interface -> Y/cpp).
This is not the case here, as Rust log implementation is a separate entity with C++ implementation being used as one of the backends.
Please confirm this is accepted both by logging and baselibs FT.
| "@score_baselibs//score/os/mocklib:unistd_mock", | ||
| "@score_baselibs//score/os/utils/mocklib:path_mock", | ||
| #"@score_baselibs//score/mw/log/test/console_logging_environment", | ||
| #"@score_baselibs//score/mw/log/tests/console_logging_environment", |
Contributor
There was a problem hiding this comment.
IMO those commented-out lines should be removed separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcinto component folders underscore#248)