docs: Update score/utils component requirement - #417
Open
rahulthakre29 wants to merge 2 commits into
Open
Conversation
rahulthakre29
requested review from
4og,
antonkri and
aschemmel-tech
as code owners
July 28, 2026 09:24
rahulthakre29
requested a deployment
to
workflow-approval
July 28, 2026 09:24 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
July 28, 2026 09:24 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
July 28, 2026 09:27 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
July 28, 2026 09:27 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
4og
added
documentation
rahulthakre29
temporarily deployed
to
workflow-approval
July 28, 2026 11:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
July 28, 2026 11:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Member
|
Hi @rahulthakre29, the inspection checklist PR was merged yesterday #269. The process is the following: as part of the addressing the findings (this PR), you also mark the addressed checklist items to YES. |
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 11:26 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 11:26 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
force-pushed
the
docs/utils-library-component-requirements-update
branch
from
July 30, 2026 11:46
696e579 to
3212c82
Compare
rahulthakre29
requested a deployment
to
workflow-approval
July 30, 2026 11:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
July 30, 2026 11:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
- Updated component requirement as per review comment on PR eclipse-score#269 - updated requirement checklist
rahulthakre29
force-pushed
the
docs/utils-library-component-requirements-update
branch
from
July 30, 2026 11:56
3212c82 to
2703ad3
Compare
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 13:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
July 30, 2026 13:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
4og
requested changes
Jul 31, 2026
| :version: 1 | ||
| :satisfied_by: comp__baselibs_utils[version==1] | ||
|
|
||
| The Utils component shall ensure a singleton is created once and safely shared by multiple threads. |
Member
There was a problem hiding this comment.
I would formulate it like this:
Suggested change
| The Utils component shall ensure a singleton is created once and safely shared by multiple threads. | |
| The Utils component shall provide a thread-safe singleton whose instance is created exactly once when accessed concurrently by multiple threads. |
| The Utils component shall provide functions for decoding Base64 data back to its original form. | ||
|
|
||
| .. comp_req:: Thread-Safe Singleton Instance Creation | ||
| :id: comp_req__utils__meyer_singleton_threadsafe |
Member
There was a problem hiding this comment.
I would drop meyer as it's implementation detail.
Suggested change
| :id: comp_req__utils__meyer_singleton_threadsafe | |
| :id: comp_req__utils__threadsafe_singleton |
| :status: valid | ||
| :version: 1 | ||
| :satisfied_by: comp__baselibs_utils[version==1] | ||
|
|
Member
There was a problem hiding this comment.
I suppose :tags: inspected is needed as it's part of the inspection. @aschemmel-tech, is it alighned with the process?
Suggested change
| :tags: inspected | |
| * :need:`comp_req__utils__scoped_operation` | ||
| * :need:`comp_req__utils__base64_encoding` | ||
| * :need:`comp_req__utils__base64_decoding` | ||
| * :need:`comp_req__utils__meyer_singleton_threadsafe` |
Member
There was a problem hiding this comment.
Suggested change
| * :need:`comp_req__utils__meyer_singleton_threadsafe` | |
| * :need:`comp_req__utils__threadsafe_singleton` |
Comment on lines
71
to
+82
| .. comp_req:: Deterministic Behavior | ||
| :id: comp_req__utils__deterministic_behavior | ||
| :reqtype: Non-Functional | ||
| :security: YES | ||
| :safety: ASIL_B | ||
| :derived_from: feat_req__baselibs__utils_library[version==2] | ||
| :status: valid | ||
| :version: 1 | ||
| :satisfied_by: comp__baselibs_utils[version==1] | ||
| :tags: inspected | ||
|
|
||
| The Utils component shall ensure that all operations complete in a predictable manner and without dynamic memory allocation. | ||
| The Utils component shall run operations proportional to input size using only stack memory. |
Member
There was a problem hiding this comment.
I would actually delete this requirement.
Suggested change
| The Utils component shall run operations proportional to input size using only stack memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #395