-
Notifications
You must be signed in to change notification settings - Fork 17
Version 1.5.0 adds :html target #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
docs/how-to/commands.md
Outdated
| | Target | What it does | | ||
| | --------------------------- | ---------------------------------------------------------------------- | | ||
| | `bazel run //:docs` | Builds documentation | | ||
| | `bazel build //:html` | Builds documentation in Bazel sandbox | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a better name here, as having docs and html is confusing.
And I would not add a build target until we considered the other DRs. The effort and direction in the last months was to get away from bazel build. Maintaining build and run targets at the same time was enormous effort in the past.
We could add an "docs_experimental_sandbox" target, if we have any usecase for it. I don't want to open a lengthy discussion here in parallel to the DRs. But as it stands today, sandbox has only downsides for the sphinx build.
📌 Description
Offers an additional Bazel target for docs-as-code users to build inside the Bazel sandbox.
As a side effect, another commit on the main branch becomes part of this version increment. If we merge this first, then we can remove the git override in this other PR.
🚨 Impact Analysis
Additional feature fully backwards compatible.
✅ Checklist