Skip to content

Replace watchdog custom OSAL with baselibs OSAL - #403

Merged
NicolasFussberger merged 6 commits into
eclipse-score:mainfrom
etas-contrib:watchdog_device_file_abstraction
Aug 4, 2026
Merged

Replace watchdog custom OSAL with baselibs OSAL#403
NicolasFussberger merged 6 commits into
eclipse-score:mainfrom
etas-contrib:watchdog_device_file_abstraction

Conversation

@NicolasFussberger

Copy link
Copy Markdown
Contributor

Replaces the custom abstraction for the following systemcalls that existed in the current watchdog implementation:

  • ioctl -> score/os/ioctl.h
  • open -> score/os/fcntl.h
  • close -> score/os/unistd.h
  • write -> score/os/unistd.h

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: bc11bcf8-1695-430f-aed0-13da8bb3f182
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (39 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (150 packages loaded, 3143 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (170 packages loaded, 8185 targets configured)

Analyzing: target //:license-check (170 packages loaded, 8185 targets configured)

Analyzing: target //:license-check (173 packages loaded, 11401 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 30.944s, Critical Path: 2.76s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Comment thread score/launch_manager/src/daemon/src/watchdog/details/WatchdogImpl.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/watchdog/details/WatchdogImpl.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/watchdog/details/WatchdogImpl.cpp Outdated

@paulquiring paulquiring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor findings

@paulquiring

Copy link
Copy Markdown
Contributor

checks are failing

@NicolasFussberger
NicolasFussberger force-pushed the watchdog_device_file_abstraction branch from 7b1063d to 629ab30 Compare August 4, 2026 07:27
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@paulquiring

Copy link
Copy Markdown
Contributor

Lets merge tests will be added in another PR.

@NicolasFussberger
NicolasFussberger merged commit bb7b965 into eclipse-score:main Aug 4, 2026
21 of 22 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants