-
Notifications
You must be signed in to change notification settings - Fork 14
update modules to latest mains #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update modules to latest mains #31
Conversation
cd56f08 to
f60d039
Compare
|
The created documentation from the pull request is available at: docu-html |
882df5e to
22dd5aa
Compare
dcalavrezo-qorix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces automation to update module dependencies to their latest commits on specified branches, addressing issue #1849. The changes enable the integration test workflow to automatically fetch and test the latest versions of all SCORE modules instead of using fixed commits.
- Adds Python tools to fetch latest commits from GitHub and generate Bazel module configurations
- Updates integration test script to display module versions and track build failures
- Configures GitHub Actions workflow to run nightly builds with latest module versions
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/update_module_latest.py | New script to query GitHub API for latest commits and update known_good.json |
| tools/update_module_from_known_good.py | New script to generate Bazel MODULE files from known_good.json |
| tools/requirements.txt | Adds PyGithub dependency for GitHub API access |
| tools/get_module_info.py | New utility script to extract module information from known_good.json |
| known_good.json | Adds initial module configuration with versions and commit hashes |
| integration_test.sh | Enhanced to accept known_good.json file, display module versions, and track failures |
| README.md | Fixed incorrect module reference in communication build command |
| MODULE.bazel | Added missing bazel_dep declarations for rules_boost and trlc |
| .github/workflows/test_integration.yml | Updated to run nightly, fetch latest commits, and generate module configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
integration_test.sh
Outdated
| echo "| TOTAL | | | ${overall_warn_total} | ${overall_depr_total} |" >> "${SUMMARY_FILE}" | ||
|
|
||
| # Display the full build summary explicitly at the end | ||
| echo "| TOTAL | | | ${overall_warn_total} | ${overall_depr_total} | |" >> "${SUMMARY_FILE}"# Display the full build summary explicitly at the end |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space before comment. Add a newline or space between the pipe symbol and the comment.
| exit 0 | ||
| # Report to GitHub Actions if any build group failed | ||
| if [[ ${any_failed} -eq 1 ]]; then | ||
| echo "::error::One or more build groups failed. See summary above." |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script does not exit with non-zero status when builds fail. After line 173, add exit 1 to ensure the script returns a failure exit code when any_failed is set.
| echo "::error::One or more build groups failed. See summary above." | |
| echo "::error::One or more build groups failed. See summary above." | |
| exit 1 |
| @@ -0,0 +1 @@ | |||
| PyGithub>=2.1.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this actually used? I also cannot find someone using this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update_module_latest.sh has the option to use the PyGithub instead of gh cli
resolves eclipse-score/score#1849