Skip to content

Conversation

@egekorkan
Copy link
Member

closes #115

I have used config of node-wot but I do not have a strong preference. I have added the config and the dependencies in the first commit, formatting in the second.

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for thingweb ready!

Name Link
🔨 Latest commit 01865d9
🔍 Latest deploy log https://app.netlify.com/projects/thingweb/deploys/687791a7f2e8480008903da2
😎 Deploy Preview https://deploy-preview-141--thingweb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 41 (🔴 down 40 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

package.json Outdated
"@docusaurus/module-type-aliases": "^3.5.2",
"@docusaurus/types": "^3.5.2"
"@docusaurus/types": "^3.5.2",
"prettier": "^3.6.2"
Copy link
Member

@danielpeintner danielpeintner Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion but on node-wot side we used a fixed version, see

https://github.com/eclipse-thingweb/node-wot/blob/699e6b6cc640c60a1ca338050d496f59af7646f7/package.json#L74

to overcome issues with the GitHub actions

https://github.com/eclipse-thingweb/node-wot/blob/699e6b6cc640c60a1ca338050d496f59af7646f7/.github/workflows/ci.yaml#L102-L109

As the problem is not relevant here I am fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to put gh action so maybe it is an issue here too. I will fix the version and add gh action

@danielpeintner
Copy link
Member

@egekorkan package-lock is missing..

@egekorkan
Copy link
Member Author

@danielpeintner have another look after your approval from last time

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egekorkan egekorkan merged commit a166660 into master Jul 16, 2025
7 checks passed
@egekorkan egekorkan deleted the ege-prettier branch July 16, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure prettier

4 participants