Small changes for alpha4 #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
reviewed
Dec 2, 2025
Contributor
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Hey @MaximilianToe 👋 thanks for putting in these improvements.
Could you take a look at the main comment I left about linting seeming to fail in CI?
| #include <uprotocol/v1/uri.pb.h> | ||
|
|
||
| uprotocol::v1::UUri getUUri(int const resource_id) { | ||
| constexpr int DUMMY_UE_ID = 0x18002; |
Contributor
There was a problem hiding this comment.
When I checked the lint step, here, I saw that it looks like this fails, but the status returned is still okay.
Am I reading the CI correctly here? Or missing something?
Contributor
Author
There was a problem hiding this comment.
Let me have a look. To be honest, I only looked at the status at the end of the CI and trusted that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some small changes to prepare for the release of alpha4. These include the following: